rc/vmz
1
0
Fork 0
Code Issues 33 Pull requests 3 Projects Releases Packages Wiki Activity Actions

libvmz: return immediate status from async operations #29

New issue
Open
opened 2026-05-22 10:38:05 +00:00 by rc · 0 comments
rc commented 2026-05-22 10:38:05 +00:00
Owner
Copy link

Problem:

  • Asynchronous functions return void.
  • vmz_start and vmz_force_stop cannot synchronously report immediate misuse such as NULL handle, NULL callback, invalid state, or failed scheduling.

Why this is bad:

  • Immediate API misuse and eventual operation failure are different categories.
  • Returning void pushes every problem into callbacks or undefined behavior.
  • C callers expect a fast status return for argument/state validation.

Suggested fix:

  • Make async operations return VMZStatus immediately.
  • Use the callback only for eventual operation completion.
  • Validate handle, callback, and VM state before starting async work.

Relevant code:

  • lib/libvmz.h: vmz_start and vmz_force_stop return void.
  • lib/libvmz.swift: functions directly dereference opaque handles and invoke async framework calls.
Problem: - Asynchronous functions return void. - vmz_start and vmz_force_stop cannot synchronously report immediate misuse such as NULL handle, NULL callback, invalid state, or failed scheduling. Why this is bad: - Immediate API misuse and eventual operation failure are different categories. - Returning void pushes every problem into callbacks or undefined behavior. - C callers expect a fast status return for argument/state validation. Suggested fix: - Make async operations return VMZStatus immediately. - Use the callback only for eventual operation completion. - Validate handle, callback, and VM state before starting async work. Relevant code: - lib/libvmz.h: vmz_start and vmz_force_stop return void. - lib/libvmz.swift: functions directly dereference opaque handles and invoke async framework calls.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/verbose-logging
codex-fix-run-without-initrd
codex-package-libvmz
swfit
output
No results found.
Labels
Clear labels   
highprio

   
lowprio
No labels
highprio
lowprio
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rc/vmz#29
No description provided.